Add test coverage for multi-dash @id header resolution #2930
Open
singhharsh1708 wants to merge 1 commit intoJuliaDocs:masterfrom
Open
Add test coverage for multi-dash @id header resolution #2930singhharsh1708 wants to merge 1 commit intoJuliaDocs:masterfrom
singhharsh1708 wants to merge 1 commit intoJuliaDocs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause (dashed @ref being misclassified as Julia expressions)
was fixed in #2678 via DASHED_XREF_ID_REGEX. This adds an explicit
test for the successful case: a header defined with a multi-dash @id
(multi-word-section-id) and a @ref that correctly resolves to it.
Closes #2732