You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hmm, I like the idea, but it'd still call get_backend on inputs; we wanted to avoid that when backend is explicitly specified, so that unmaterialised arrays (e.g. UnitRange) would work in GPU kernels.
A bit of a nitpick, but could we rename use_KA_algo to something fully snake_case to be consistent with the rest of the library? Perhaps use_gpu_backend? It can technically work on CPUs via PoCL, but it still goes through the GPUCompiler infrastructure, which is the main thing here.
Also, is there a way to have the buildkite badges in the README point to the latest merged commit? No problem if not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method will be more resilient for if/when we support broadcasted containers and not just AbstractArrays.