Conversation
vchuravy
commented
Apr 12, 2024
vchuravy
added a commit
to JuliaLang/julia
that referenced
this pull request
Apr 15, 2024
…reters (#54069) Partially reverts #49391 PrecompileTools uses the timing infrastructure to snoop on the inference process. The reason for #49391 was that this could lead to accidental pollution of the caches with foreign results (JuliaDebug/SnoopCompile.jl#338) After #52233 and especially #53336 we now filter results by cache owner and don't try to cache foreign code using the native pipeline. Motivated by JuliaGPU/GPUCompiler.jl#567 which demonstrated that a foreign code instance would not be cached without PrecompileTools.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #567 +/- ##
==========================================
- Coverage 83.04% 82.96% -0.09%
==========================================
Files 24 24
Lines 3345 3352 +7
==========================================
+ Hits 2778 2781 +3
- Misses 567 571 +4 ☔ View full report in Codecov by Sentry. |
vchuravy
commented
Apr 16, 2024
| return llvm_mod, compiled | ||
| end | ||
|
|
||
| function CC.typeinf(interp::GPUInterpreter, frame::CC.InferenceState) |
Member
Author
There was a problem hiding this comment.
Shouldn't do things without drinking coffee first. This should needs a version bound to limit it for 1.11.
In 1.11-beta2 it should not be necessary anymore
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Apr 17, 2024
…reters (#54069) Partially reverts #49391 PrecompileTools uses the timing infrastructure to snoop on the inference process. The reason for #49391 was that this could lead to accidental pollution of the caches with foreign results (JuliaDebug/SnoopCompile.jl#338) After #52233 and especially #53336 we now filter results by cache owner and don't try to cache foreign code using the native pipeline. Motivated by JuliaGPU/GPUCompiler.jl#567 which demonstrated that a foreign code instance would not be cached without PrecompileTools. (cherry picked from commit c0611e8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.