Make MSC & find_maximum_chroma robust to implementations of conversions#492
Merged
kimikage merged 1 commit intoJuliaGraphics:masterfrom Jun 20, 2021
Merged
Make MSC & find_maximum_chroma robust to implementations of conversions#492kimikage merged 1 commit intoJuliaGraphics:masterfrom
MSC & find_maximum_chroma robust to implementations of conversions#492kimikage merged 1 commit intoJuliaGraphics:masterfrom
Conversation
…rsions This reduces the hard-coded constants. This also avoids unnecessary gamma correction in the out-of-gamut checking.
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
==========================================
+ Coverage 93.12% 93.16% +0.03%
==========================================
Files 9 9
Lines 1018 1009 -9
==========================================
- Hits 948 940 -8
+ Misses 70 69 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the hard-coded constants.
This also avoids unnecessary gamma correction in the out-of-gamut checking.
A part of this has been separated from PR #482.