Optimize pow5_12(::Float32)#493
Merged
kimikage merged 1 commit intoJuliaGraphics:masterfrom Jun 23, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 93.40% 93.47% +0.06%
==========================================
Files 9 9
Lines 1061 1072 +11
==========================================
+ Hits 991 1002 +11
Misses 70 70
Continue to review full report at Codecov.
|
Collaborator
Author
Benchmarkcf. #482 (comment) julia> @btime convert.(RGB, $xyz_f32);
36.715 ms (2 allocations: 11.44 MiB) # before (PR #482)
31.418 ms (2 allocations: 11.44 MiB) # after
julia> @btime convert.(RGB{N0f8}, $xyz_f32);
42.136 ms (2 allocations: 2.86 MiB) # before (PR #482)
40.123 ms (2 allocations: 2.86 MiB) # after |
Collaborator
Author
|
The connection between the curve and the line in julia> Float64(big"0.0031308"^(5/big"12") * big"1.055" - big"0.055")
0.04044990748269015
julia> Float64(big"0.0031308" * big"12.92") # != 0.04045
0.040449936 |
99810b3 to
c4ae4f9
Compare
kimikage
added a commit
to kimikage/Colors.jl
that referenced
this pull request
May 11, 2024
kimikage
added a commit
that referenced
this pull request
May 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without PR #482,
pow5_12(::Float32)was never called because linear RGB values are promoted toFloat64in the transform matrix multiplication.The new
pow5_12(::Float32)has an accuracy of about 0.5 ULP.