Skip to content

Conversation

@github-actions
Copy link
Contributor

This pull request changes the compat entry for the MRIReco package from 0.6, 0.7, 0.8 to 0.6, 0.7, 0.8, 0.9.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.66%. Comparing base (4d7519e) to head (c547251).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
- Coverage   90.94%   90.66%   -0.28%     
==========================================
  Files          53       53              
  Lines        2926     2926              
==========================================
- Hits         2661     2653       -8     
- Misses        265      273       +8     
Flag Coverage Δ
base 88.20% <ø> (ø)
core 91.19% <ø> (-1.50%) ⬇️
files 93.55% <ø> (ø)
komamri 93.98% <ø> (ø)
plots 89.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Contributor Author

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KomaMRI Benchmarks

Benchmark suite Current: c547251 Previous: 4d7519e Ratio
MRI Lab/Bloch/CPU/2 thread(s) 235490706.5 ns 243211040 ns 0.97
MRI Lab/Bloch/CPU/4 thread(s) 175159624 ns 135699416 ns 1.29
MRI Lab/Bloch/CPU/8 thread(s) 146330699 ns 146055228.5 ns 1.00
MRI Lab/Bloch/CPU/1 thread(s) 362985929 ns 408609577.5 ns 0.89
MRI Lab/Bloch/GPU/CUDA 57024631 ns 57044600 ns 1.00
MRI Lab/Bloch/GPU/oneAPI 514759410.5 ns 520674051 ns 0.99
MRI Lab/Bloch/GPU/Metal 545187104 ns 558646396 ns 0.98
MRI Lab/Bloch/GPU/AMDGPU 37098057 ns 36907276.5 ns 1.01
Slice Selection 3D/Bloch/CPU/2 thread(s) 1007912195 ns 1018197659 ns 0.99
Slice Selection 3D/Bloch/CPU/4 thread(s) 583742073 ns 623218694 ns 0.94
Slice Selection 3D/Bloch/CPU/8 thread(s) 382047585.5 ns 382864848.5 ns 1.00
Slice Selection 3D/Bloch/CPU/1 thread(s) 1942306155 ns 2261868516 ns 0.86
Slice Selection 3D/Bloch/GPU/CUDA 101201614.5 ns 100807488.5 ns 1.00
Slice Selection 3D/Bloch/GPU/oneAPI 658189569.5 ns 652815075.5 ns 1.01
Slice Selection 3D/Bloch/GPU/Metal 563930437 ns 563682791 ns 1.00
Slice Selection 3D/Bloch/GPU/AMDGPU 60363296 ns 61205236 ns 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@cncastillo cncastillo merged commit 57f8698 into master Aug 20, 2024
@cncastillo cncastillo deleted the compathelper/new_version/2024-08-14-00-40-24-701-00541212617 branch August 20, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants