pass extra save_stream keywords to image2wand#199
Conversation
johnnychen94
changed the title
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
==========================================
+ Coverage 70.52% 74.58% +4.05%
==========================================
Files 3 3
Lines 397 421 +24
==========================================
+ Hits 280 314 +34
+ Misses 117 107 -10
Continue to review full report at Codecov.
|
johnnychen94
force-pushed
the
jc/stream_kw
branch
from
697fbb8 to
29dec6e
Compare
johnnychen94
force-pushed
the
jc/stream_kw
branch
from
fa8b46f to
2ca32fc
Compare
|
The failure in ubuntu is reproducible locally and seems to be an SSL certificate issue. julia> download("http://magnushoff.com/assets/test-exiforientation.zip")
┌ Error: Download failed: curl: (60) SSL certificate problem: unable to get local issuer certificate
└ @ Base download.jl:43
ERROR: failed process: Process(`curl -s -S -g -L -f -o /tmp/jl_3ekIQ8 http://magnushoff.com/assets/test-exiforientation.zip`, ProcessExited(60)) [60] |
| fn = joinpath(workdir, "2by2_fromstream.png") | ||
| open(fn, "w") do f | ||
| ImageMagick.save(Stream(format"PNG", f), orig_img) | ||
| ImageMagick.save(Stream{format"PNG"}(f), orig_img) |
There was a problem hiding this comment.
Interesting how much disruption this depwarn causes. Tests will fail unless FileIO >= 1.6, but I guess we can live with that, and it won't happen in CI or an update test environment.
Interesting. Can we generate a "data artifact" and stop worrying about downloading this freshly each time? I haven't really followed that world very well. |
|
This file is only 4Kb (less than the 4kb block size) so I think we're good to commit it to the git? |
|
That works for me unless there's some license/whatever reason that we can't. |
so as to avoid SSL issue when downloading http://magnushoff.com/assets/test-exiforientation.zip this zip file is less than 4Kb so won't be an issue by directly commiting it into git
Similar to the save_ method for filename, this PR passes extra keywords to image2wand. An example of this is a stream gif saving with fps keyword. Also fixes a FileIO depwarn in the tests.
2 participants
Similar to the
save_method for filename, this PR passes extra keywords toimage2wand. An example of this is a stream gif saving with fps keyword. (JuliaImages/ImageShow.jl#30)Also fixes a FileIO depwarn in the tests.