Skip to content

Dataset show improvements#680

Merged
JonasIsensee merged 2 commits intomasterfrom
dataset-show-improvements
Nov 16, 2025
Merged

Dataset show improvements#680
JonasIsensee merged 2 commits intomasterfrom
dataset-show-improvements

Conversation

@JonasIsensee
Copy link
Copy Markdown
Collaborator

This is experimental ai coding work with Claude and copilot.

Will hopefully be add a few features in this way that are tedious to implement, test and document but provide quality of life improvements for users.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces comprehensive improvements to dataset display functionality, including enhanced introspection for Julia data types and extensive test coverage. The changes provide better error handling and more informative display output for JLD2 datasets.

  • Adds safe type introspection capabilities that avoid type reconstruction errors during dataset display
  • Implements comprehensive test suite for dataset show functionality with multiple test scenarios
  • Updates test artifacts to version 0.1.9 for expanded test coverage

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/test_files.jl Updates test artifact version to 0.1.9 with sync comment
test/test_dataset_show.jl New comprehensive test suite for dataset display functionality
test/runtests.jl Includes the new dataset show test file
test/Artifacts.toml Updates artifact references to version 0.1.9
src/explicit_datasets.jl Major enhancement of dataset display with safe introspection and detailed documentation
src/datatypes.jl Adds julia_repr method for FixedLengthString
src/data/specialcased_types.jl Minor whitespace addition
src/committed_datatype_introspection.jl New comprehensive safe introspection system for committed datatypes
src/Filters.jl Fixes FilterPipeline constructor type annotation
Comments suppressed due to low confidence (1)

src/explicit_datasets.jl:1

  • Magic number 0x37 should be defined as a named constant. Consider defining const DT_REFERENCE = 0x37 to improve code readability and maintainability.
#=

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/Filters.jl
Comment thread test/test_dataset_show.jl
Comment thread src/committed_datatype_introspection.jl Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 20, 2025

Codecov Report

❌ Patch coverage is 89.69072% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.44%. Comparing base (36349bb) to head (c76ea85).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/committed_datatype_introspection.jl 83.78% 6 Missing ⚠️
src/explicit_datasets.jl 92.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
+ Coverage   85.37%   88.44%   +3.06%     
==========================================
  Files          37       37              
  Lines        4445     4481      +36     
==========================================
+ Hits         3795     3963     +168     
+ Misses        650      518     -132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JonasIsensee JonasIsensee force-pushed the dataset-show-improvements branch 3 times, most recently from 91561c0 to 06c6874 Compare November 16, 2025 16:25
@JonasIsensee JonasIsensee force-pushed the dataset-show-improvements branch from 7a2a851 to 0682ef7 Compare November 16, 2025 17:04
@JonasIsensee JonasIsensee force-pushed the dataset-show-improvements branch from 0682ef7 to c76ea85 Compare November 16, 2025 17:05
@JonasIsensee JonasIsensee merged commit 834a3f1 into master Nov 16, 2025
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants