-
Notifications
You must be signed in to change notification settings - Fork 14
Add ability to write pixel density into pngs #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| @testset "dpi" begin | ||
| io_none = IOBuffer() | ||
| io_300 = IOBuffer() | ||
| io_300_300 = IOBuffer() | ||
| io_300_500 = IOBuffer() | ||
|
|
||
| img = rand(RGB{N0f8}, 2, 2) | ||
|
|
||
| PNGFiles.save(io_none, img; dpi = nothing) | ||
| PNGFiles.save(io_300, img; dpi = 300) | ||
| PNGFiles.save(io_300_300, img; dpi = (300f0, 300.0)) | ||
| PNGFiles.save(io_300_500, img; dpi = (300, 500)) | ||
|
|
||
| for io in [io_none, io_300, io_300_300, io_300_500] | ||
| seekstart(io) | ||
| @test PNGFiles.load(io) == img | ||
| end | ||
|
|
||
| s_none = String(take!(io_none)) | ||
|
timholy marked this conversation as resolved.
|
||
| s_300 = String(take!(io_300)) | ||
| s_300_300 = String(take!(io_300_300)) | ||
| s_300_500 = String(take!(io_300_500)) | ||
|
|
||
| function physblock(xdpi, ydpi) | ||
| io = IOBuffer() | ||
| write(io, "pHYs") | ||
| write(io, hton(round(UInt32, xdpi / 0.0254))) | ||
| write(io, hton(round(UInt32, ydpi / 0.0254))) | ||
| write(io, hton(UInt8(1))) | ||
| return String(take!(io)) | ||
| end | ||
|
|
||
| @test !occursin("pHYs", s_none) | ||
| @test occursin(physblock(300, 300), s_300) | ||
| @test occursin(physblock(300, 300), s_300_300) | ||
| @test occursin(physblock(300, 500), s_300_500) | ||
| end | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pixels per meter seems to be native to PNG (cf. https://www.w3.org/TR/PNG-Chunks.html), and it is using an SI unit, so even though DPI may be more common, why not at least support both a
pixels_per_meterand adots_per_inchkeyword?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would also be possible, I just don't think anybody will really use that :)