only expose thickness and fill as keyword#58
Merged
johnnychen94 merged 2 commits intomasterfrom Apr 19, 2021
Merged
Conversation
When things become complex, it will be a nightmare to fix the method ambiguity with too many positional argument. Because keyword parameters are not used in method dispatch, it is more friendly to both users and maintainers. This commit also fixes the incremental complilation issue; there are two duplicated methods.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up #51
When things become complex, it will be a nightmare to fix the method
ambiguity with too many positional argument. Because keyword parameters
are not used in method dispatch, it is more friendly to both users and
maintainers.
This commit also fixes the incremental complilation issue; there are two
duplicated methods.
cc: @ashwani-rathee