Skip to content

Fixes FileIO 1.6 deprecation#31

Merged
johnnychen94 merged 1 commit intomasterfrom
jc/fileio
Mar 11, 2021
Merged

Fixes FileIO 1.6 deprecation#31
johnnychen94 merged 1 commit intomasterfrom
jc/fileio

Conversation

@johnnychen94
Copy link
Copy Markdown
Member

See https://github.com/JuliaIO/FileIO.jl/pull/309/files for the compat note.

This fixes the test failures in master.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2021

Codecov Report

Merging #31 (b68b1bc) into master (9cd9440) will decrease coverage by 1.06%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   90.54%   89.47%   -1.07%     
==========================================
  Files           2        3       +1     
  Lines          74       76       +2     
==========================================
+ Hits           67       68       +1     
- Misses          7        8       +1     
Impacted Files Coverage Δ
src/ImageShow.jl 40.00% <ø> (ø)
src/compat.jl 50.00% <50.00%> (ø)
src/showmime.jl 94.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd9440...b68b1bc. Read the comment docs.

@johnnychen94 johnnychen94 merged commit 48ababc into master Mar 11, 2021
@johnnychen94 johnnychen94 deleted the jc/fileio branch March 11, 2021 21:46
@timholy
Copy link
Copy Markdown
Member

timholy commented Mar 11, 2021

Thanks for doing this! What were the test failures? A depwarn shouldn't trigger a failure, so this concerning.

@johnnychen94
Copy link
Copy Markdown
Member Author

johnnychen94 commented Mar 11, 2021

The warning message in

@test_logs (:info, r"^For better quality") show(file, MIME("image/png"), Gray.(A), minpixels=0, maxpixels=5)

was polluted by the FileIO depwarn. No functionality breakage.

@timholy
Copy link
Copy Markdown
Member

timholy commented Mar 12, 2021

Whew! I've had enough of those, I was worried I needed one more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants