Skip to content

[compat] support gif in Julia 1.0 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnnychen94 merged 1 commit into from
Apr 15, 2021
Merged

[compat] support gif in Julia 1.0 #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/gif.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ end
AnimatedGIF(data::AbstractArray; kwargs...) = AnimatedGIF{eltype(data), typeof(data)}(data; kwargs...)

# Display gif requires ImageMagick v1.2.0, which requires Julia 1.3
Base.showable(::MIME"image/gif", agif::AnimatedGIF) = VERSION >= v"1.3.0"
Base.showable(::MIME"image/gif", agif::AnimatedGIF) = true
function Base.show(io::IO, ::MIME"image/gif", agif::AnimatedGIF)
FileIO.save(_format_stream(format"GIF", io), agif.data; fps=agif.fps)
end
Expand All @@ -31,8 +31,8 @@ Base.@propagate_inbounds Base.getindex(A::AnimatedGIF, inds::Vararg{Int}) = geti
Convert 3D `img` or 2D frame list `frames` to animated gif array.

!!! compat "ImageMagick 1.2"
`ImageMagick` at least v1.2.0 (which requires Julia at least v1.3.0) is required to generate
gif image. You can install it via `pkg> add ImageMagick`.
ImageMagick at least 1.2 is required to generate gif image. For ImageMagick 0.y.z versions,
ImageMagick at least 0.7.7 also works.

# Arguments

Expand Down
6 changes: 1 addition & 5 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,7 @@ using Test
@testset "ImageShow" begin
include("writemime.jl")

# `gif` requires ImageMagick v1.2.0, which requires Julia 1.3
if VERSION >= v"1.3.0"
include("gif.jl")
end

include("gif.jl")
include("keyboard.jl")
include("multipage.jl")
end