Skip to content

use ImageBase.restrict#38

Merged
johnnychen94 merged 1 commit intomasterfrom
jc/imagebase
Jun 2, 2021
Merged

use ImageBase.restrict#38
johnnychen94 merged 1 commit intomasterfrom
jc/imagebase

Conversation

@johnnychen94
Copy link
Copy Markdown
Member

@johnnychen94 johnnychen94 commented Jun 2, 2021

Until now I realize that we never test ImageTransformation.restrict for more than 3 years given that it's not loaded at all.

julia> @time using ImageShow
# master: 1.113088 seconds (2.31 M allocations: 169.042 MiB, 5.48% gc time, 0.24% compilation time)
# PR:  1.177738 seconds (2.35 M allocations: 172.266 MiB, 4.79% gc time, 0.29% compilation time)

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 2, 2021

Codecov Report

Merging #38 (e83e600) into master (6b60ba0) will increase coverage by 0.77%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   86.42%   87.20%   +0.77%     
==========================================
  Files           6        6              
  Lines         221      211      -10     
==========================================
- Hits          191      184       -7     
+ Misses         30       27       -3     
Impacted Files Coverage Δ
src/ImageShow.jl 0.00% <ø> (-40.00%) ⬇️
src/showmime.jl 97.18% <100.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b60ba0...e83e600. Read the comment docs.

@johnnychen94 johnnychen94 merged commit b1a777a into master Jun 2, 2021
@johnnychen94 johnnychen94 deleted the jc/imagebase branch June 2, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant