eagerly convert to Array type before sending to IO backend#45
Merged
johnnychen94 merged 3 commits intomasterfrom Oct 22, 2021
Merged
eagerly convert to Array type before sending to IO backend#45johnnychen94 merged 3 commits intomasterfrom
johnnychen94 merged 3 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 87.20% 88.58% +1.38%
==========================================
Files 6 6
Lines 211 219 +8
==========================================
+ Hits 184 194 +10
+ Misses 27 25 -2
Continue to review full report at Codecov.
|
johnnychen94
force-pushed
the
jc/array
branch
from
5183c93 to
9c0b248
Compare
The current ImageMagick version for Julia >= 1.3 is a bit broken for PNG files because the built ImageMagick_jll is broken. JuliaIO/ImageMagick.jl#206 This commit work arounds this bug by adding ImageIO dependency. Because ImageIO has higher priority in the FileIO registry, it will use the PNGFiles to load the data instead of using the broken ImageMagick.
johnnychen94
force-pushed
the
jc/array
branch
from
9c0b248 to
f5b4be0
Compare
johnnychen94
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids JuliaIO/PNGFiles.jl#43 but we should also do the same in PNGFiles.jl
closes #39
closes #40
cc: @tlnagy