Revert #51 and test Pluto integration#52
Merged
johnnychen94 merged 1 commit intoJuliaImages:masterfrom May 17, 2022
Merged
Conversation
Merged
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 87.28% 87.98% +0.69%
==========================================
Files 6 6
Lines 236 233 -3
==========================================
- Hits 206 205 -1
+ Misses 30 28 -2
Continue to review full report at Codecov.
|
johnnychen94
approved these changes
May 17, 2022
Member
johnnychen94
left a comment
johnnychen94
left a comment
There was a problem hiding this comment.
Since the current Pollen codebase hasn't used it yet, I believe it's safe to remove this hot patch.
cc: @lorenzoh
Contributor
|
Go ahead! I just need to revert some changes in FeatureRegistries.jl, but those weren't registered yet 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #51 (comment)