Skip to content

make default html show fullmode#53

Merged
johnnychen94 merged 2 commits intomasterfrom
jc/fullmode
May 17, 2022
Merged

make default html show fullmode#53
johnnychen94 merged 2 commits intomasterfrom
jc/fullmode

Conversation

@johnnychen94
Copy link
Copy Markdown
Member

@johnnychen94 johnnychen94 commented May 17, 2022

Resolves the comment in #51 (comment)

I still think that the downscaling done by the HTML show method can be confusing, because it happens secretly, and it is not possible to control this behaviour.

@fonsp Thanks for catching this! I believe I made a mistake in #50 that assumes IOContext downsamples image by default -- but we should not.

For the ImageShow.preview(img) thing, people might just refer to ImageBase.restrict or ImageTransformations.imresize.

@codecov
Copy link
Copy Markdown

codecov bot commented May 17, 2022

Codecov Report

Merging #53 (0eb0a32) into master (ce60b0a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   87.28%   87.28%           
=======================================
  Files           6        6           
  Lines         236      236           
=======================================
  Hits          206      206           
  Misses         30       30           
Impacted Files Coverage Δ
src/showmime.jl 95.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce60b0a...0eb0a32. Read the comment docs.

@johnnychen94 johnnychen94 merged commit d5b2c47 into master May 17, 2022
@fonsp
Copy link
Copy Markdown
Contributor

fonsp commented May 17, 2022

Yayyy thanks Johnny!!

@johnnychen94 johnnychen94 deleted the jc/fullmode branch May 17, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants