Skip to content

Update Project.toml#2

Open
ashwanirathee wants to merge 1 commit intomasterfrom
ash/update
Open

Update Project.toml#2
ashwanirathee wants to merge 1 commit intomasterfrom
ash/update

Conversation

@ashwanirathee
Copy link
Member

@ashwanirathee ashwanirathee commented Jul 8, 2023

  • New version, @timholy I wonder if we should start with 1.0.0 because I am serious about maintaining this for ImageComponentAnalysis.jl

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8c33987) 93.86% compared to head (6170296) 93.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
  Coverage   93.86%   93.86%           
=======================================
  Files          12       12           
  Lines         212      212           
=======================================
  Hits          199      199           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ashwanirathee ashwanirathee requested review from timholy and removed request for timholy July 8, 2023 18:55
@zygmuntszpak
Copy link
Member

zygmuntszpak commented Oct 3, 2023

@ashwani-rathee @timholy I'd like to swap out the current dependency in ImageComponentAnalysis.jl from PlanarConvexHulls.jl to this one, but I'm not sure how we should proceed, given that this repo is a fork of PlanarConvexHulls.jl. Do we have to systematically change the name of the package from PlanarConvexHulls.jl to Polygon.jl and register that, and only then will I be able to swap out the dependency?

@ashwanirathee
Copy link
Member Author

@zygmuntszpak I think after #4, it's ready to register again pls check once again though if I missed out anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants