Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## kc/nightly #1003 +/- ##
===========================================
Coverage 84.07% 84.07%
===========================================
Files 3 3
Lines 829 829
===========================================
Hits 697 697
Misses 132 132 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Member
Author
|
Okay, nightly CI is passing on this PR (after increasing the timeout). |
Member
Author
|
I've merged this into #1002. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets
kc/nightly(#1002).It looks like nightly CI times have increased, maybe due to the changes in Julia master regarding
Compilerbeing moved out.I suspect that nightly CI will timeout on Kristoffer's PR (#1002).
This PR (which targets #1002) increases some of our timeouts from 1.5 hours (90 minutes) to 2.5 hours (150 minutes).