Replace hardcoded version filter with skip-versions.txt#44
Merged
ViralBShah merged 1 commit intoJuliaLang:masterfrom Mar 14, 2026
Merged
Replace hardcoded version filter with skip-versions.txt#44ViralBShah merged 1 commit intoJuliaLang:masterfrom
ViralBShah merged 1 commit intoJuliaLang:masterfrom
Conversation
ViralBShah
force-pushed
the
skip-versions-list
branch
2 times, most recently
from
80634e3 to
675a754
Compare
Replace hardcoded version filters with a skip list file. This makes it easy to add versions that fail without code changes. - Remove the pre-release version filter from collect_versions() - Add pdf/skip-versions.txt with pre-releases < 1.5 and confirmed build failures - Make checksum verification optional (some pre-releases lack .sha256) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ViralBShah
force-pushed
the
skip-versions-list
branch
from
675a754 to
4b2e67d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the hardcoded
(v.major, v.minor) < (1, 5)filter with apdf/skip-versions.txtfile listing versions to skip. This makes it easy to add or remove versions without code changes.Changes:
pdf/skip-versions.txtwith known failures: pre-releases < 1.5, confirmed CI build failures (1.8.0-rc2, 1.9.0-beta1), and tags without binaries (1.13.0-alpha1)collect_versions()loads the skip list and filters against it.sha256files on S3Adding a new skip: just append the version number to
pdf/skip-versions.txt— no Julia code changes needed.Supersedes #43.
Test plan
🤖 Generated with Claude Code