Fix commit-pdfs: git add, artifact upload, DEV cleanup, no-op guard#47
Merged
ViralBShah merged 1 commit intoJuliaLang:masterfrom Mar 14, 2026
Merged
Conversation
438cac9 to
55c11aa
Compare
- Remove DEV PDFs when a matching release PDF exists (e.g. delete julia-1.12.6-DEV.pdf once julia-1.12.6.pdf is built) - Also remove the corresponding .commit marker file - Fix git add splatting: $(files...) concatenates filenames into one string; $files correctly passes them as separate arguments Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
55c11aa to
e49ae26
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several issues in the
commit()function and workflow that caused two consecutive failures on master (#45, #46):Bug fixes
git addsplatting:$(files...)in a JuliaCmdconcatenates filenames into one string (file1.pdffile2.pdf). Replaced withgit add -Awhich correctly stages all changes.commitfiles not uploaded as artifacts: The upload pattern was*.pdfonly, so nightly commit markers were lost between build and commit jobs. Added*.committo the artifact uploadgit push -f: Push was called twice — once inside the conditional, once unconditionally after. Removed the duplicategit commit --amend+git push -fwould rewrite history unnecessarily. Now checksgit diff --cached --quietand skips if nothing to commitNew feature
julia-1.12.6.pdf), automatically removes the correspondingjulia-1.12.6-DEV.pdfand its.commitmarker from the assets branchNightly safety
1.10.11instead of1.10.12-DEV) are now skipped to avoid overwriting release PDFsTest plan
commit-pdfsjob succeeds (no moregit adderrors).commitfiles appear on the assets branch🤖 Generated with Claude Code