Many packages fail with `julia: /source/src/module.c:107: update_implicit_resolution: Assertion resolution.binding_or_const' failed.` on 1.13

[KristofferC]

The following packages fail with the assertion in the title on 1.13:

 "AlgebraicInference"
 "AlgebraicRewriting"
 "Catlab"
 "CombinatorialSpaces"
 "GenieFramework"
 "GeometricIntegrators"
 "GeometricIntegratorsDiffEq"
 "GeometricMachineLearning"
 "GeometricProblems"
 "IntervalLinearAlgebra"
 "ProToPortal"
 "RegNets"
 "RobustBlindVerification"
 "Spehulak"
 "StippleCharts"
 "StipplePlotlyExport"
 "VeriQuEST"

A concrete stacktrace is e.g.

     Testing Running tests...
julia: /source/src/module.c:107: update_implicit_resolution: Assertion `resolution.binding_or_const' failed.

[16] signal 6 (-6): Aborted
in expression starting at /home/pkgeval/.julia/packages/Stipple/Ird4L/src/Stipple.jl:22
unknown function (ip: 0x772a5ad88ebc) at /lib/x86_64-linux-gnu/libc.so.6
gsignal at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
abort at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
unknown function (ip: 0x772a5ad24394) at /lib/x86_64-linux-gnu/libc.so.6
__assert_fail at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
update_implicit_resolution at /source/src/module.c:107 [inlined]
jl_resolve_implicit_import at /source/src/module.c:316
jl_resolve_implicit_import at /source/src/module.c:1715 [inlined]
jl_replace_binding_locked2 at /source/src/module.c:1716
ijl_module_using at /source/src/module.c:1395
jl_f__using at /source/src/builtins.c:1585
_eval_using at ./module.jl:138
jfptr__eval_using_28575.1 at /opt/julia/lib/julia/sys.so (unknown line)
_jl_invoke at /source/src/gf.c:4116 [inlined]
ijl_apply_generic at /source/src/gf.c:4313
jl_apply at /source/src/julia.h:2275 [inlined]
do_call at /source/src/interpreter.c:123
eval_value at /source/src/interpreter.c:243
eval_stmt_value at /source/src/interpreter.c:194 [inlined]
eval_body at /source/src/interpreter.c:679
jl_interpret_toplevel_thunk at /source/src/interpreter.c:884
jl_toplevel_eval_flex at /source/src/toplevel.c:742
jl_eval_toplevel_stmts at /source/src/toplevel.c:585
jl_toplevel_eval_flex at /source/src/toplevel.c:683
jl_eval_toplevel_stmts at /source/src/toplevel.c:585
jl_eval_module_expr at /source/src/toplevel.c:248 [inlined]
jl_toplevel_eval_flex at /source/src/toplevel.c:650
jl_eval_toplevel_stmts at /source/src/toplevel.c:585
jl_toplevel_eval_flex at /source/src/toplevel.c:683
jl_eval_toplevel_stmts at /source/src/toplevel.c:585
jl_toplevel_eval_flex at /source/src/toplevel.c:683
ijl_toplevel_eval at /source/src/toplevel.c:754
ijl_toplevel_eval_in at /source/src/toplevel.c:799
eval at ./boot.jl:489

Cf https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/5abf758_vs_01a2ead/report.html.

[KristofferC]

A bit of an MWE:

julia> using Reexport

julia> @reexport using Genie

julia> @reexport using Genie.Renderer.Html
julia: /home/kc/julia1.13/src/module.c:109: update_implicit_resolution: Assertion `resolution.binding_or_const' failed.

[883931] signal 6 (-6): Aborted
in expression starting at REPL[3]:1
unknown function (ip: 0x7f00e2c9890c) at /usr/lib/libc.so.6
gsignal at /usr/lib/libc.so.6 (unknown line)
abort at /usr/lib/libc.so.6 (unknown line)
unknown function (ip: 0x7f00e2c254e2) at /usr/lib/libc.so.6
update_implicit_resolution at /home/kc/julia1.13/src/module.c:109 [inlined]
jl_resolve_implicit_import at /home/kc/julia1.13/src/module.c:339

[KristofferC]

Bisected to 60a9f69 (cc @Keno)

I'll see if I can MWE it more.

[KristofferC]

MWE:

module G
    export Q

    module V
        export Q
        struct Q end
    end

    module H
        using ..G
        using ..V
        export Q
    end

    using .H

    module Q
    end
end


using .G
export Q
using .G.H

[KristofferC]

AI suggests something like:

diff --git i/src/module.c w/src/module.c
index 639aa54f04..dffc01706c 100644
--- i/src/module.c
+++ w/src/module.c
@@ -105,6 +105,14 @@ static void update_implicit_resolution(struct implicit_search_resolution *to_upd
         // Ignore guard imports
         return;
     }
+    if (resolution.ultimate_kind == PARTITION_KIND_FAILED) {
+        // Ambiguous resolution - propagate failure without debug info.
+        to_update->ultimate_kind = PARTITION_KIND_FAILED;
+        to_update->binding_or_const = NULL;
+        to_update->debug_only_import_from = NULL;
+        to_update->debug_only_ultimate_binding = NULL;
+        return;
+    }

[Keno]

AI patch is mechanistically plausible, but I probably wouldn't write it quite this way. Will debug it myself though to fully make sure I understand.

[Keno]

Simpler reproducer

julia> module AmbiguousUsing60659A
           using Test
           module A
               export X
               module B; struct X; end; export X; end
               module C; struct X; end; export X; end
               using .B, .C
           end
           module D; struct X; end; export X; end
           using .D, .A
       end
Main.AmbiguousUsing60659A

julia> AmbiguousUsing60659A.X
julia: /workspace/src/module.c:109: update_implicit_resolution: Assertion `resolution.binding_or_const' failed.

Discussed with @JeffBezanson that the correct behavior is an UndefVarError - non-assert build current returns D.X (depending on resolution order possibly).