Skip to content

improve deprecating modules that moved to stdlib#24843

Merged
JeffBezanson merged 1 commit intomasterfrom
vc/deprecated_Stdlib
Nov 29, 2017
Merged

improve deprecating modules that moved to stdlib#24843
JeffBezanson merged 1 commit intomasterfrom
vc/deprecated_Stdlib

Conversation

@vchuravy
Copy link
Copy Markdown
Member

fixes #24832
fixes #24488

Copy link
Copy Markdown
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we could fix the @deprecate_moved too?

julia> DateTime(1)
ERROR: Base.DateTime has been moved to the standard library package Dates.
Restart Julia and then run `using Dates` to load it.

@vchuravy
Copy link
Copy Markdown
Member Author

So instead of:

@deprecate_moved DateTime "Dates" true true
@deprecate DateTime (root_module(:DateTime)).DateTime

@vchuravy
Copy link
Copy Markdown
Member Author

Will address the @deprecate_moved in a different PR later this week, since I would like to land this first.

@ararslan ararslan added deprecation This change introduces or involves a deprecation stdlib Julia's standard library labels Nov 29, 2017
@JeffBezanson JeffBezanson merged commit a73f9c9 into master Nov 29, 2017
@JeffBezanson JeffBezanson deleted the vc/deprecated_Stdlib branch November 29, 2017 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation This change introduces or involves a deprecation stdlib Julia's standard library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Importing from stdlib modules using the deprecated name gives an error getfield on deprecated module returns Void

4 participants