remove bad method specialization from cache#39429
Merged
KristofferC merged 1 commit intomasterfrom Jan 29, 2021
Merged
Conversation
This was inserting a method with signature [Int, Int], rather than
Tuple{typeof(+), Int, Int}. Fix that and add a test for it so it doesn't
happen again.
vtjnash
added
backport 1.6
Member
|
Can you explain the bug? Specifically, is the "Revise-oriented precompiles" just a cleanup, and the real bug is in |
Member
Author
|
The indentation changes are just noise. Here's the diff without it: https://github.com/JuliaLang/julia/pull/39429/files?diff=unified&w=1. Specifically, it was just passing in the wrong objects to this function, and those were getting processed without checking their types (in C). |
KristofferC
pushed a commit
that referenced
this pull request
Jan 29, 2021
This was inserting a method with signature [Int, Int], rather than
Tuple{typeof(+), Int, Int}. Fix that and add a test for it so it doesn't
happen again.
(cherry picked from commit b9f8b8b)
KristofferC
pushed a commit
that referenced
this pull request
Feb 1, 2021
This was inserting a method with signature [Int, Int], rather than
Tuple{typeof(+), Int, Int}. Fix that and add a test for it so it doesn't
happen again.
(cherry picked from commit b9f8b8b)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
This was inserting a method with signature [Int, Int], rather than
Tuple{typeof(+), Int, Int}. Fix that and add a test for it so it doesn't
happen again.
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
This was inserting a method with signature [Int, Int], rather than
Tuple{typeof(+), Int, Int}. Fix that and add a test for it so it doesn't
happen again.
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
This was inserting a method with signature [Int, Int], rather than
Tuple{typeof(+), Int, Int}. Fix that and add a test for it so it doesn't
happen again.
(cherry picked from commit b9f8b8b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this bug (which was moved in cc1623b, but originally introduced in 4c4e078) while exploring code internals
Those were backported, so this needs to be also.