Fix overflow when rounding#42033
Merged
simonbyrne merged 1 commit intoJuliaLang:masterfrom Sep 7, 2021
Merged
Conversation
Member
Author
|
@simonbyrne Would you mind checking this bugfix as the original author? |
Member
|
Thanks @petvana! Apologies for the delay. |
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #37171. It simply uses a smaller step (square root of it) twice if it overflows. Otherwise, the computation remains exactly the same as before (and thus should not break any code).
Cc to the original author: @simonbyrne
The performance remains almost the same. Tested on i5-1035G1 by
Master:
This PR:
(The performance drop for 5+ digits is caused by the exponent while computing the step, see #42031)