revert promotions of abstract arrays inside other arrays#47893
Merged
KristofferC merged 1 commit intomasterfrom Dec 19, 2022
Merged
revert promotions of abstract arrays inside other arrays#47893KristofferC merged 1 commit intomasterfrom
KristofferC merged 1 commit intomasterfrom
Conversation
KristofferC
force-pushed
the
kc/promotions_arrays
branch
from
d5e0091 to
76a5259
Compare
This was referenced Dec 14, 2022
vtjnash
reviewed
Dec 14, 2022
Member
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
SGTM. We might want to run a subset of PkgEval to check if someone tried to update to the new rule system and check if this might break that (in which case we might need to keep the first 2 rules, and just remove or change the 3rd to promote_type(T,S))
Member
Author
Hopefully, we'll catch that in the PkgEval for 1.9. It feels a bit overkill to run an entire run here. |
KristofferC
added a commit
that referenced
this pull request
Dec 19, 2022
(cherry picked from commit 427432e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45511, fixes #44939, fixes #44821, reopens #43551.