complete false & true more generally as vals#51326
Merged
IanButterworth merged 2 commits intoJuliaLang:masterfrom Sep 15, 2023
Merged
complete false & true more generally as vals#51326IanButterworth merged 2 commits intoJuliaLang:masterfrom
IanButterworth merged 2 commits intoJuliaLang:masterfrom
Conversation
IanButterworth
commented
Sep 15, 2023
|
|
||
| suggestions = Completion[KeywordArgumentCompletion(kwarg) for kwarg in kwargs] | ||
| append!(suggestions, complete_symbol(nothing, last_word, Returns(true), context_module)) | ||
| append!(suggestions, complete_keyval(last_word)) |
Member
Author
There was a problem hiding this comment.
This is the actual fix
IanButterworth
commented
Sep 15, 2023
IanButterworth
added
backport 1.9
giordano
approved these changes
Sep 15, 2023
Member
giordano
left a comment
giordano
left a comment
There was a problem hiding this comment.
I'm not familiar with REPL internals, but I can confirm this PR fixes the reported problem, thanks! I'm also not sure why false and true were in sorted_keywords together with the other keyword, it doesn't feel like they fit together with them
Member
Author
|
Agreed. I do think this change is logical, and if this does break anything, there weren't tests for it, and it can be tweaked. |
NHDaly
pushed a commit
that referenced
this pull request
Sep 20, 2023
IanButterworth
added a commit
that referenced
this pull request
Oct 4, 2023
(cherry picked from commit e85f0a5)
31 tasks
KristofferC
added a commit
that referenced
this pull request
Nov 2, 2023
Backported PRs: - [x] #50932 <!-- types: fix hash values of Vararg --> - [x] #50975 <!-- Use rr-safe `nopl; rdtsc` sequence --> - [x] #50989 <!-- fix incorrect results in `expm1(::Union{Float16, Float32})` --> - [x] #51284 <!-- Avoid infinite loop when doing SIGTRAP in arm64-apple --> - [x] #51332 <!-- Add s4 field to Xoshiro --> - [x] #51397 <!-- call Pkg precompile hook in latest world --> - [x] #51405 <!-- Remove fallback that assigns a module to inlined frames. --> - [x] #51491 <!-- Throw clearer ArgumentError for strip with two string args --> - [x] #51531 <!-- fix `_tryonce_download_from_cache` (busybox.exe download error) --> - [x] #51541 <!-- Fix string index error in tab completion code --> - [x] #51530 <!-- Don't mark nonlocal symbols as hidden --> - [x] #51557 <!-- Fix last startup & shutdown precompiles --> - [x] #51512 <!-- avoid limiting Type{Any} to Type --> - [x] #51595 <!-- reset `maxprobe` on `empty!` --> - [x] #51582 <!-- Aggressive constprop in LinearAlgebra.wrap --> - [x] #51592 <!-- correctly track element pointer in heap snapshot --> - [x] #51326 <!-- complete false & true more generally as vals --> - [x] #51376 <!-- make `hash(::Xoshiro)` compatible with `==` --> - [x] #51557 <!-- Fix last startup & shutdown precompiles --> - [x] #51845 - [x] #51840 - [x] #50663 <!-- Fix Expr(:loopinfo) codegen --> - [x] #51863 <!-- LLVM 15.0.7-9 --> Contains multiple commits, manual intervention needed: - [ ] #51035 <!-- refactor GC scanning code to reflect jl_binding_t are now first class --> - [ ] #51092 <!-- inference: fix bad effects for recursion --> Non-merged PRs with backport label: - [ ] #51479 <!-- prevent code loading from lookin in the versioned environment when building Julia --> - [ ] #51414 <!-- improvements on GC scheduler shutdown --> - [ ] #51366 <!-- Handle infix operators in REPL completion --> - [ ] #50919 <!-- Code loading: do the "skipping mtime check for stdlib" check regardless of the value of `ispath(f)` --> - [ ] #50824 <!-- Add some aliasing warnings to docstrings for mutating functions in Base --> - [ ] #49805 <!-- Limit TimeType subtraction to AbstractDateTime -->
KristofferC
removed
the
backport 1.10
nalimilan
pushed a commit
that referenced
this pull request
Nov 5, 2023
(cherry picked from commit e85f0a5)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49892
I'm not sure whether separating the concepts of "keyvals" for
false&truefrom the list of "keywords" is strictly correct, but they seem to be different conceptually.