Backport "Fix Expr(:loopinfo) codegen"#51883
Merged
vchuravy merged 4 commits intobackports-release-1.10from Oct 28, 2023
Merged
Backport "Fix Expr(:loopinfo) codegen"#51883vchuravy merged 4 commits intobackports-release-1.10from
vchuravy merged 4 commits intobackports-release-1.10from
Conversation
We used a loop-marker intrinsic because the LoopID used to be dropped by optimization passes (this seems no longer true). got optimized by simplifycfg to the point where the loop-marker is now attached to the wrong back-edge. This PR drops the loop-marker and uses the LoopID metadata node directly. (cherry picked from commit 90494c2)
brenhinkeller
added
compiler:codegen
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #50663 to 1.10