export jl_alloc_array_nd, re-add convenience wrappers#52248
Merged
maleadt merged 3 commits intoJuliaLang:masterfrom Dec 4, 2023
Merged
export jl_alloc_array_nd, re-add convenience wrappers#52248maleadt merged 3 commits intoJuliaLang:masterfrom
jl_alloc_array_nd, re-add convenience wrappers#52248maleadt merged 3 commits intoJuliaLang:masterfrom
Conversation
Contributor
|
Could you also export the 2d and 3d constructors instead of marking them as static inline? I use both those functions in jlrs and dealing with static inlines is kind of awkward. |
vtjnash
approved these changes
Nov 21, 2023
Contributor
Author
I think that's reasonable since they were exported before, done in 4e6e1a7. |
Contributor
|
Thanks, I appreciate it! |
Member
|
It would be great to have this, to unbreak some JLLs resp. allow us to fix them w/o too much of a headache. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is used in an example here in the docs https://docs.julialang.org/en/v1.11-dev/manual/embedding/#Multidimensional-Arrays and needed to adapt to the removed
jl_alloc_array_2d(#51319).I also added inline convenience wrappers for
jl_alloc_array_2dandjl_alloc_array_3dto un-break existing code, both functions were removed in the Memory PR in favor of the_ndvariant. If this is undesired I can remove them again and only keep the new export.