split internal dates methods into separate functions#53692
split internal dates methods into separate functions#53692quinnj merged 1 commit intoJuliaLang:masterfrom
Conversation
|
bump |
|
Loads of tests have been broken by this PR, it shouldn't have been merged, I'm going to revert it |
Reverts #53692, this broke tests.
|
@aplavin this PR is now reverted. You're welcome to resubmit again a working version, but all tests and checks were failing to your changes well before your bump, and this PR shouldn't have been merged in that state. Please be more careful next time and fix the breakage before bumping. |
|
Sorry, I guess I just got used to tests often being broken unrelated to the changes in PRs, and didn't look into them... These specific changes obviously don't introduce any new functionality. I submitted them for the sole reason of getting an error message instead of a weird result back, when passing unexpected types to these Dates functions. |
|
I think these changes are appropriate, we just also need to adjust the CI tests to allow for them, and run nanosoldier to make sure people don't actually rely on them. |
These methods are clearly internal: not documented, and with unclear semantics in the general case.
They lead to weird results instead of errors:
So, would be best to really remove them from public functions (hope noone relies on them).