fixes to colonful reshape#54261
Merged
oscardssmith merged 3 commits intoJuliaLang:masterfrom May 13, 2024
Merged
Conversation
N5N3
reviewed
Apr 29, 2024
In several different situations `reshape` had thrown `DivideError` instead of returning a correct result or throwing. Fixes JuliaLang#54245
8a9ebaf to
30823c9
Compare
30823c9 to
f1fc62f
Compare
Member
Author
|
ping |
1 similar comment
Member
Author
|
ping |
oscardssmith
approved these changes
May 13, 2024
Member
|
The type assertions added here appear to have broken reshape using julia> using FillArrays
julia> reshape(Fill(1, 2), big(2), :)
2×1 Fill{Int64}, with entries equal to 1Edit: |
Member
Author
|
Lines 129 to 130 in b0b7a85 |
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Jul 12, 2024
This was referenced Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54245