inference: follow up #54323, override ssaflags with new cycle effects#54689
Merged
inference: follow up #54323, override ssaflags with new cycle effects#54689
Conversation
aviatesk
added
compiler:inference
aviatesk
force-pushed
the
avi/override-ssaflags-54323
branch
from
878ca04 to
b7ac60a
Compare
Member
|
We do already have a list of the back edges and their statement numbers. Would it be easier to walk that list instead? |
Member
Author
|
My understanding is that this PR does that (specifically, traversing |
aviatesk
force-pushed
the
avi/override-ssaflags-54323
branch
from
b7ac60a to
c9a5560
Compare
Member
|
I was referencing |
aviatesk
force-pushed
the
avi/override-ssaflags-54323
branch
from
c9a5560 to
73d4077
Compare
Member
|
LGTM, though may want to update the commit message now |
Member
Author
Thanks, that should be far more efficient. |
Member
Author
|
Updated the PR description, and I will use it for an incoming commit description. |
#54323 ensures that all frames within a cycle have the same, cycle valid effects. However, `src.ssaflags` is calculated using partial effects, so when the effects of a `frame` within the cycle are updated, there would be an inconsistency between `frame.ipo_effects` and `frame.src.ssaflags`. Due to this inconsistency, #54323 breaks the test cases from #51092, when backported to v1.11. On the surface this is because #52999 hasn't been backported to v1.11, but the fundamental issue lies in this inconsistency between cycle effects and `ssaflags`. To resolve this issue, this commit traverses `cycle_backedges` to visit statements involved in the cycle, and updates each `ssaflags` according to new cycle valid effects if necessary.
aviatesk
force-pushed
the
avi/override-ssaflags-54323
branch
from
73d4077 to
8ac9368
Compare
Member
Author
|
The |
aviatesk
added a commit
that referenced
this pull request
Jun 7, 2024
…#54689) #54323 ensures that all frames within a cycle have the same, cycle valid effects. However, `src.ssaflags` is calculated using partial effects, so when the effects of a `frame` within the cycle are updated, there would be an inconsistency between `frame.ipo_effects` and `frame.src.ssaflags`. Due to this inconsistency, #54323 breaks the test cases from #51092, when backported to v1.11. On the surface this is because #52999 hasn't been backported to v1.11, but the fundamental issue lies in this inconsistency between cycle effects and `ssaflags`. To resolve this issue, this commit traverses `cycle_backedges` to visit statements involved in the cycle, and updates each `ssaflags` according to new cycle valid effects if necessary.
aviatesk
removed
merge me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#54323 ensures that all frames within a cycle have the
same, cycle valid effects. However,
src.ssaflagsis calculated usingpartial effects, so when the effects of a
framewithin the cycle areupdated, there would be an inconsistency between
frame.ipo_effectsandframe.src.ssaflags. Due to this inconsistency, #54323breaks the test cases from #51092, when backported to
v1.11. On the surface this is because #52999 hasn't been
backported to v1.11, but the fundamental issue lies in this
inconsistency between cycle effects and
ssaflags.To resolve this issue, this commit traverses
cycle_backedgesto visitstatements involved in the cycle, and updates each
ssaflagsaccordingto new cycle valid effects if necessary.