Revert "add logic to prefer loading modules that are already loaded #55908" to fix Revise#56076
Closed
KristofferC wants to merge 2 commits intomasterfrom
Closed
Revert "add logic to prefer loading modules that are already loaded #55908" to fix Revise#56076KristofferC wants to merge 2 commits intomasterfrom
KristofferC wants to merge 2 commits intomasterfrom
Conversation
This reverts commit 4cdd864.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#55908 was accidentally merged even though it broke Revise. This was not noticed because Revise test was accidentally marked as soft failure. Revert this to get back to a good state so the Revise tests can be marked as non soft and the PR can be added back in a non-breaking way (or with a fix to Revise master) after that.