Conversation
51 tasks
timholy
reviewed
Apr 5, 2025
|
|
||
| get_require_world() = unsafe_load(cglobal(:jl_require_world, UInt)) | ||
|
|
||
| function gen_staged_sig(def::Method, mi::MethodInstance) |
Member
There was a problem hiding this comment.
This file feels like a slightly strange place to define this, but obviously not really a problem
| for k = 1:length(result) | ||
| match = result[k]::Core.MethodMatch | ||
| genmethod = match.method | ||
| # no, I refuse to refuse to recurse into your cursed generated function generators and will only test one level deep here |
We already have an excellent framework for selective code reuse, so use that tool instead of a sledgehammer for inserting selective coverage and malloc instrumentation. As a small bonus, this should also be significantly more accurate by not being vulnerable to precompilation inserting incorrect (uninstrumented) contents into the caches.
vtjnash
force-pushed
the
jn/fast-coverage
branch
from
5a31e48 to
33a5700
Compare
KristofferC
pushed a commit
that referenced
this pull request
Apr 16, 2025
We already have an excellent framework for selective code reuse, so use that tool instead of a sledgehammer for inserting selective coverage and malloc instrumentation. As a small bonus, this should also be significantly more accurate by not being vulnerable to precompilation inserting incorrect (uninstrumented) contents into the caches. (cherry picked from commit 5fedf47)
KristofferC
pushed a commit
that referenced
this pull request
Apr 16, 2025
We already have an excellent framework for selective code reuse, so use that tool instead of a sledgehammer for inserting selective coverage and malloc instrumentation. As a small bonus, this should also be significantly more accurate by not being vulnerable to precompilation inserting incorrect (uninstrumented) contents into the caches. (cherry picked from commit 5fedf47)
KristofferC
removed
the
backport 1.12
DilumAluthge
removed
the
merge me
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
We already have an excellent framework for selective code reuse, so use that tool instead of a sledgehammer for inserting selective coverage and malloc instrumentation. As a small bonus, this should also be significantly more accurate by not being vulnerable to precompilation inserting incorrect (uninstrumented) contents into the caches.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have an excellent framework for selective code reuse, so use that tool instead of a sledgehammer for inserting selective coverage and malloc instrumentation. As a small bonus, this should also be significantly more accurate by not being vulnerable to precompilation inserting incorrect (uninstrumented) contents into the caches.