Merged
Conversation
vtjnash
reviewed
Apr 3, 2025
vtjnash
reviewed
Apr 3, 2025
vtjnash
approved these changes
Apr 3, 2025
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
timholy
added a commit
that referenced
this pull request
Apr 9, 2025
Edge invalidations of the form
```julia
Package InvalidA:
module InvalidA
f(::Integer) = 1
invokesfs(x) = invoke(f, Tuple{Signed}, x)
end
Package InvalidB:
module InvalidB
using InvalidA
InvalidA.invokesfs(1) # precompile
end
```
used as
```julia
using PkgA
InvalidA.f(::Signed) = 4
using PkgB
```
did not formerly attribute a "cause":
```
...
Tuple{typeof(InvalidA.f), Signed}
"insert_backedges_callee"
CodeInstance for MethodInstance for InvalidA.invokesfs(::Int64)
nothing
...
```
This fills in the new method that replaced the previous dispatch.
---------
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
(cherry picked from commit 15e0deb)
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on JuliaDebug/SnoopCompile.jl#418 I noticed that the edge invalidation (but not the corresponding method-insertion invalidation) of the form
used as
did not attribute a "cause":
This aims to fill in the new method that replaced the previous dispatch.