inference: re-enable inference overload for basic statements#58027
Merged
inference: re-enable inference overload for basic statements#58027
Conversation
After #55575, inference for basic statements got inlined into `typeinf_local`. But external abstract interpreters like JET.jl need to overload this inference to customize this behavior. So this commit extracts the inlined inference logic back out into a separate `abstract_eval_basic_statement` method.
3 tasks
aviatesk
added a commit
that referenced
this pull request
Apr 8, 2025
After #55575, inference for basic statements got inlined into `typeinf_local`. But external abstract interpreters like JET.jl need to overload this inference to customize this behavior. So this commit extracts the inlined inference logic back out into a separate `abstract_eval_basic_statement` method.
aviatesk
added a commit
that referenced
this pull request
Apr 21, 2025
#58027 introduced 5~10% performance regression in the `"inference"` benchmark. This commit fixes the regression by inlining `abstract_eval_basic_statement` that was outlined in the PR.
KristofferC
pushed a commit
that referenced
this pull request
Apr 22, 2025
KristofferC
pushed a commit
that referenced
this pull request
Apr 22, 2025
KristofferC
removed
the
backport 1.12
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
…ng#58027) After JuliaLang#55575, inference for basic statements got inlined into `typeinf_local`. But external abstract interpreters like JET.jl need to overload this inference to customize this behavior. So this commit extracts the inlined inference logic back out into a separate `abstract_eval_basic_statement` method.
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
LebedevRI
pushed a commit
to LebedevRI/julia
that referenced
this pull request
May 2, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #55575, inference for basic statements got inlined into
typeinf_local. But external abstract interpreters like JET.jl need to overload this inference to customize this behavior. So this commit extracts the inlined inference logic back out into a separateabstract_eval_basic_statementmethod.