Skip to content

Print fallback REPL prompt before user input#58210

Merged
xal-0 merged 5 commits intoJuliaLang:masterfrom
xal-0:fallback-repl-prompt
Apr 30, 2025
Merged

Print fallback REPL prompt before user input#58210
xal-0 merged 5 commits intoJuliaLang:masterfrom
xal-0:fallback-repl-prompt

Conversation

@xal-0
Copy link
Copy Markdown
Member

@xal-0 xal-0 commented Apr 23, 2025

Using the fallback REPL interactively prints the prompt only after user input, making the scrollback confusing:

$ JULIA_FALLBACK_REPL=1 julia          
1 + 2
julia> 3

@xal-0 xal-0 added the bugfix This change fixes an existing bug label Apr 23, 2025
@LilithHafner LilithHafner requested a review from vtjnash April 24, 2025 16:31
Comment thread base/client.jl Outdated
xal-0 and others added 2 commits April 25, 2025 11:35
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@vtjnash vtjnash added merge me PR is reviewed. Merge when all tests are passing backport 1.12 Change should be backported to release-1.12 labels Apr 28, 2025
@KristofferC KristofferC mentioned this pull request Apr 29, 2025
53 tasks
@xal-0 xal-0 merged commit ccef01a into JuliaLang:master Apr 30, 2025
6 of 7 checks passed
@xal-0 xal-0 deleted the fallback-repl-prompt branch April 30, 2025 18:17
KristofferC pushed a commit that referenced this pull request May 5, 2025
Using the fallback REPL interactively prints the prompt only after user
input, making the scrollback confusing:
```
$ JULIA_FALLBACK_REPL=1 julia
1 + 2
julia> 3
```

---------

Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
(cherry picked from commit ccef01a)
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label May 5, 2025
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label May 9, 2025
charleskawczynski pushed a commit to charleskawczynski/julia that referenced this pull request May 12, 2025
Using the fallback REPL interactively prints the prompt only after user
input, making the scrollback confusing:
```
$ JULIA_FALLBACK_REPL=1 julia          
1 + 2
julia> 3
```

---------

Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This change fixes an existing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants