Closed
Conversation
This quiets down the long message in #38136 to be once-per-process when running with `--depwarn=yes` instead of spamming log files continually. We probably should have considered doing this a long time ago, but hopefully better now than never.
vtjnash
added
needs decision
53 tasks
Member
|
Triage thinks doing this without without printing file+line-number is a really bad idea since it will make it impossible to tell whether you've fixed an instance or not. In general, triage thinks that we really need to report line numbers from our depwanrs. |
Member
Author
|
If you still get the message, then you haven't fixed it? I don't quite follow that concern. |
Member
|
If you have 3 instances of the message, and you de-duplicate the warnings, when you fix one of the 3 places causing a warning, there still exist 2 more, so you will not see any change in output. |
58 tasks
Member
Author
|
Alright, spam the user with useless message it is |
Member
|
Can we get a different PR that adds the line numbers to make the message useful instead? |
KristofferC
removed
backport 1.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This quiets down the long message in #38136 to be once-per-process when running with
--depwarn=yesinstead of spamming log files continually. We probably should have considered doing this a long time ago, but hopefully better now than never.