don't use IndexSCartesian2 in reshaped reinterpreted array with 0-dim parent#58824
Closed
adienes wants to merge 1 commit intoJuliaLang:masterfrom
Closed
don't use IndexSCartesian2 in reshaped reinterpreted array with 0-dim parent#58824adienes wants to merge 1 commit intoJuliaLang:masterfrom
IndexSCartesian2 in reshaped reinterpreted array with 0-dim parent#58824adienes wants to merge 1 commit intoJuliaLang:masterfrom
Conversation
adienes
added
arrays
Member
Author
|
@N5N3 , I saw you've written a decent amount of |
Member
Member
Author
|
I will try it. my understanding of what exactly fixes what became slightly higgledy-piggledy working on all three prs concurrently 😇 edit: it does. I'll consolidate the test case there and close this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #54623
found while writing (but unrelated to) #58814