Fix precompiling when there's no manifest#59212
Merged
IanButterworth merged 3 commits intoJuliaLang:masterfrom Aug 7, 2025
Merged
Fix precompiling when there's no manifest#59212IanButterworth merged 3 commits intoJuliaLang:masterfrom
IanButterworth merged 3 commits intoJuliaLang:masterfrom
Conversation
Member
Author
|
@KristofferC I'd appreciate another set of eyes on this. It's breaking Pkg CI so good to get in quick. |
Member
Author
|
I'll merge as this needs fixing to unblock e.g. Pkg CI, but review still appreciated |
KristofferC
pushed a commit
that referenced
this pull request
Oct 12, 2025
(cherry picked from commit e4a3a2a)
KristofferC
pushed a commit
that referenced
this pull request
Oct 14, 2025
(cherry picked from commit e4a3a2a)
Member
|
It appears that this change inadvertently causes the exception |
Member
Author
|
I think I was unaware that was possible before... I guess it makes sense. Mind opening an issue? |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59206
Here there's no Manifest.toml in the Pkg repo