Skip to content

docs(compat): Add missing compat admonition to IdSet docstring#59290

Merged
IanButterworth merged 2 commits intoJuliaLang:masterfrom
kunzaatko:IdSet-compat
Aug 22, 2025
Merged

docs(compat): Add missing compat admonition to IdSet docstring#59290
IanButterworth merged 2 commits intoJuliaLang:masterfrom
kunzaatko:IdSet-compat

Conversation

@kunzaatko
Copy link
Copy Markdown
Contributor

No description provided.

@ViralBShah
Copy link
Copy Markdown
Member

Can we make this into a positive - as in which is the first version this is introduced in? I think the compat entry should be 1.11 and the comment should say it is exported from 1.11 onwards.

@kunzaatko
Copy link
Copy Markdown
Contributor Author

Yeah, I thought about that. It is probably better. Here is the updated version. Would you change the phrasing, or is this alright?

@nsajko nsajko added docs This change adds or pertains to documentation collections Data structures holding multiple items, e.g. sets merge me PR is reviewed. Merge when all tests are passing labels Aug 22, 2025
@IanButterworth IanButterworth merged commit 096011c into JuliaLang:master Aug 22, 2025
10 checks passed
@ViralBShah ViralBShah added backport 1.12 Change should be backported to release-1.12 and removed merge me PR is reviewed. Merge when all tests are passing labels Aug 22, 2025
KristofferC pushed a commit that referenced this pull request Sep 1, 2025
KristofferC pushed a commit that referenced this pull request Sep 2, 2025
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Sep 11, 2025
KristofferC pushed a commit that referenced this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

collections Data structures holding multiple items, e.g. sets docs This change adds or pertains to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants