Skip to content

[backports-release-1.11] Fix namespace of IOError in random_seed#59689

Merged
DilumAluthge merged 1 commit intobackports-release-1.11from
jishnub/RNGs_random_seed_IOError_namespace
Jan 21, 2026
Merged

[backports-release-1.11] Fix namespace of IOError in random_seed#59689
DilumAluthge merged 1 commit intobackports-release-1.11from
jishnub/RNGs_random_seed_IOError_namespace

Conversation

@jishnub
Copy link
Copy Markdown
Member

@jishnub jishnub commented Sep 29, 2025

This PR addresses an issue with IOError not being exported from Base and therefore being unavailable within Random if not fully qualified.

I'm not entirely certain which branch to make this PR to: release-1.11 or backports-release-1.11. Please change the target branch to the appropriate one if necessary.

@rfourquet
Copy link
Copy Markdown
Member

LGTM. Regarding the correct branch, let's ask @KristofferC.

@DilumAluthge
Copy link
Copy Markdown
Member

Yep, it should target the backports branch (backports-release-1.11). I'll make that change.

@DilumAluthge DilumAluthge changed the base branch from release-1.11 to backports-release-1.11 January 19, 2026 19:19
@DilumAluthge DilumAluthge force-pushed the jishnub/RNGs_random_seed_IOError_namespace branch from 511aaf7 to 889bb5e Compare January 19, 2026 19:19
@DilumAluthge DilumAluthge changed the title [release-1.11] Fix namespace of IOError in random_seed [backports-release-1.11] Fix namespace of IOError in random_seed Jan 19, 2026
@DilumAluthge
Copy link
Copy Markdown
Member

@rfourquet Is this good to merge into the backports branch (assuming CI passes)?

@DilumAluthge DilumAluthge force-pushed the backports-release-1.11 branch from 3d73b64 to 29b3528 Compare January 19, 2026 19:28
@DilumAluthge DilumAluthge force-pushed the jishnub/RNGs_random_seed_IOError_namespace branch from 889bb5e to 3a6dda2 Compare January 21, 2026 21:02
@DilumAluthge
Copy link
Copy Markdown
Member

Bump @rfourquet - Is this good to merge into the backports branch (assuming CI passes)?

@jishnub
Copy link
Copy Markdown
Member Author

jishnub commented Jan 21, 2026

I think it should be fine. A similar PR has been merged in the 1.12 branch as well.

@DilumAluthge
Copy link
Copy Markdown
Member

It looks pretty benign

@DilumAluthge DilumAluthge merged commit e29b8e6 into backports-release-1.11 Jan 21, 2026
2 of 6 checks passed
@DilumAluthge DilumAluthge deleted the jishnub/RNGs_random_seed_IOError_namespace branch January 21, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants