Conversation
oscardssmith
added
bugfix
Keno
approved these changes
Nov 1, 2025
Member
Keno
left a comment
Keno
left a comment
There was a problem hiding this comment.
Ok, but might as well implement this properly and constant fold (can be a follow up though).
Member
Author
|
It already has good effects, so it should constant fold, right? |
Member
|
Constant folding is handled elsewhere (to avoid needing to duplicate that every time you ever write a tfunc) |
vtjnash
approved these changes
Nov 1, 2025
17 tasks
KristofferC
removed
the
backport 1.12
KristofferC
removed
the
backport 1.13
kpamnany
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jan 21, 2026
fixes JuliaLang#60009 (cherry picked from commit 97f880a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #60009