Skip to content

loading: improve precompilation cache reason messages#60012

Merged
vtjnash merged 1 commit intomasterfrom
jn/59255
Nov 3, 2025
Merged

loading: improve precompilation cache reason messages#60012
vtjnash merged 1 commit intomasterfrom
jn/59255

Conversation

@vtjnash
Copy link
Copy Markdown
Member

@vtjnash vtjnash commented Nov 1, 2025

Make cache invalidation reason messages clearer and more user-friendly by removing abbreviations and using more positive, informative language.

Changes include:

  • Expanded all abbreviations (e.g., "dep" → "dependency", "fsize" → "file size")
  • Replaced negative-sounding terms like "wrong" with neutral "different"
  • Made technical terms clearer (e.g., "ocachefile" → "native code cache file")
  • Changed "cache misses" to "caches not reused" for more positive framing
  • Reordered format from "reason (count)" to "count for reason" for better readability

Fixes #59255

🤖 Generated with Claude Code

Make cache invalidation reason messages clearer and more user-friendly
by removing abbreviations and using more positive, informative language.

Changes include:
- Expanded all abbreviations (e.g., "dep" → "dependency", "fsize" → "file size")
- Replaced negative-sounding terms like "wrong" with neutral "different"
- Made technical terms clearer (e.g., "ocachefile" → "native code cache file")
- Changed "cache misses" to "caches not reused" for more positive framing
- Reordered format from "reason (count)" to "count for reason" for better readability

Fixes #59255

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@vtjnash vtjnash added the backport 1.13 Change should be backported to release-1.13 label Nov 1, 2025
@IanButterworth
Copy link
Copy Markdown
Member

The language changes seem reasonable, but shouldn't the old @info precompile message not be triggered anymore, now that precompilepkgs handles any necessary serial precompilation?

Copy link
Copy Markdown
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@vtjnash vtjnash merged commit bfa0e4d into master Nov 3, 2025
9 checks passed
@vtjnash vtjnash deleted the jn/59255 branch November 3, 2025 16:56
KristofferC pushed a commit that referenced this pull request Nov 5, 2025
Make cache invalidation reason messages clearer and more user-friendly
by removing abbreviations and using more positive, informative language.

Changes include:
- Expanded all abbreviations (e.g., "dep" → "dependency", "fsize" →
"file size")
- Replaced negative-sounding terms like "wrong" with neutral "different"
- Made technical terms clearer (e.g., "ocachefile" → "native code cache
file")
- Changed "cache misses" to "caches not reused" for more positive
framing
- Reordered format from "reason (count)" to "count for reason" for
better readability

Fixes #59255

🤖 Generated with Claude Code

(cherry picked from commit bfa0e4d)
@KristofferC KristofferC mentioned this pull request Nov 5, 2025
17 tasks
@KristofferC KristofferC removed the backport 1.13 Change should be backported to release-1.13 label Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

precompile info text is confusing users

4 participants