[JuliaLowering] Reconstruct macro name before, not during, macro expansion#60170
Merged
topolarity merged 4 commits intoJuliaLang:masterfrom Dec 4, 2025
Merged
[JuliaLowering] Reconstruct macro name before, not during, macro expansion#60170topolarity merged 4 commits intoJuliaLang:masterfrom
topolarity merged 4 commits intoJuliaLang:masterfrom
Conversation
mlechu
added
the
compiler:lowering
topolarity
reviewed
Nov 25, 2025
mlechu
force-pushed
the
rehydrate-macro-name
branch
from
62e70e4 to
da7b6dc
Compare
- StyledStrings, Markdown, JuliaSyntaxHighlighting, and Profile now pass - Include REPLExt and SparseArraysExt
mlechu
force-pushed
the
rehydrate-macro-name
branch
from
622dd39 to
baa4c07
Compare
topolarity
approved these changes
Dec 4, 2025
Member
topolarity
left a comment
topolarity
left a comment
There was a problem hiding this comment.
Another nice simplification. Thanks, @mlechu !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #60162. This simplification lets macro expansion handle the macro name as an identifier rather than the nonterminal
K"macro_name"node. That and the oldMacroNamenode (as well asCmdMacroName,StrMacroName) are mainly the result of restrictions on raw parser output: we can't parse@Base.xto a non-contiguous@x, even though that's what we want in the AST in almost every case.