Don't introduce a block around y in parsing x' = y#60246
Don't introduce a block around y in parsing x' = y#60246JeffBezanson merged 1 commit intoJuliaLang:masterfrom
y in parsing x' = y#60246Conversation
That is generally how it's done - see https://github.com/JuliaLang/Pkg.jl/tree/release-1.12 + #60158 for example |
|
@mlechu @topolarity I see the |
|
Thanks for the bump. This is also contained by #60641 |
|
Needs the same process for 1.13? |
|
It looks like we may have missed a case or two: #61056 |
Closes #59911.
'is generally treated as its own thing in Expr and flisp, but treated as a special type of call in JuliaSyntax. This change makesx' = yparse to the <=1.11(= (|'| x) y)instead of wrapping the body in a block like we do when parsingf(x) = y.The special case is fine to me given that it's a more understandable parse, and we're hoping to move away from LineNumberNodes in the future anyway. (I think this was the original reason for the block-wrap for
f(x) = y).Backporting will be a pain. My plan is to get this reviewed, then make a branch
backports-xin the separate JuliaSyntax repository and push this change directly to it, then make a version bump PR to this repository'sbackports-release-xforxin 1.12, 1.13. Suggestions for how to improve this situation are welcome!