[backports-release-1.12] Fix 7z rpath#60419
[backports-release-1.12] Fix 7z rpath#60419KristofferC merged 2 commits intoJuliaLang:backports-release-1.12from
Conversation
| ifeq ($(OS), Darwin) | ||
| ifneq ($(DARWIN_FRAMEWORK),1) | ||
| for j in $(JL_PRIVATE_EXES) ; do \ | ||
| [ $$j = 7z ] && continue; \ |
There was a problem hiding this comment.
Yes, this prevented it from getting set correctly during install
There was a problem hiding this comment.
You may still need to delete this for the patch to be applied
|
@KristofferC Is there a way to backport this fix to 1.12? I just tested this, and it allows Julia to run and install packages in a container with the system |
|
Looks like this was auto-closed when the backports PR was merged. I've created a new backports branch. |
2f26e1b to
041af6a
Compare
|
@vtjnash Can you review this? |
|
Julia 1.12.4 is in testing period currently. I think we should probably wait until 1.12.4 is released. After that, a new backports PR will be opened (for the future 1.12.5), and then we can merge this PR into the 1.12 backports branch. @nhz2 Can you ping me once 1.12.4 has been released? |
|
I think we should get this into 1.12.4. It is a bugfix to an existing 1.12 issue. |
4539b7b
into
JuliaLang:backports-release-1.12
Attempt to fix #60220
This was copied from the current makefile
julia/Makefile
Lines 530 to 559 in 3b1a5b6