Skip to content

[backports-release-1.12] Fix 7z rpath#60419

Merged
KristofferC merged 2 commits intoJuliaLang:backports-release-1.12from
nhz2:nz/backport-1.12-p7zip-rpath-fix
Dec 22, 2025
Merged

[backports-release-1.12] Fix 7z rpath#60419
KristofferC merged 2 commits intoJuliaLang:backports-release-1.12from
nhz2:nz/backport-1.12-p7zip-rpath-fix

Conversation

@nhz2
Copy link
Copy Markdown
Member

@nhz2 nhz2 commented Dec 18, 2025

Attempt to fix #60220

This was copied from the current makefile

julia/Makefile

Lines 530 to 559 in 3b1a5b6

ifeq ($(OS), Darwin)
ifneq ($(DARWIN_FRAMEWORK),1)
for j in $(JL_PRIVATE_TOOLS) ; do \
[ -L $(DESTDIR)$(private_libexecdir)/$$j ] && continue; \
install_name_tool -rpath @loader_path/$(build_libdir_rel) @executable_path/$(reverse_private_libexecdir_rel) $(DESTDIR)$(private_libexecdir)/$$j || exit 1; \
done
endif
else ifneq (,$(findstring $(OS),Linux FreeBSD))
for j in $(JL_PRIVATE_TOOLS) ; do \
[ -L $(DESTDIR)$(private_libexecdir)/$$j ] && continue; \
$(PATCHELF) $(PATCHELF_SET_RPATH_ARG) '$$ORIGIN/$(reverse_private_libexecdir_rel)' $(DESTDIR)$(private_libexecdir)/$$j || exit 1; \
done
endif
ifneq ($(reverse_private_libexecdir_rel),$(reverse_build_private_libexecdir_rel))
ifeq ($(OS), Darwin)
ifneq ($(DARWIN_FRAMEWORK),1)
for j in $(JL_PRIVATE_EXES) ; do \
[ $$j = 7z ] && continue; \
[ -L $(DESTDIR)$(private_libexecdir)/$$j ] && continue; \
install_name_tool -rpath @executable_path/$(reverse_build_private_libexecdir_rel) @executable_path/$(reverse_private_libexecdir_rel) $(DESTDIR)$(private_libexecdir)/$$j || exit 1; \
done
endif
else ifneq (,$(findstring $(OS),Linux FreeBSD))
for j in $(JL_PRIVATE_EXES) ; do \
[ -L $(DESTDIR)$(private_libexecdir)/$$j ] && continue; \
$(PATCHELF) $(PATCHELF_SET_RPATH_ARG) '$$ORIGIN/$(reverse_private_libexecdir_rel)' $(DESTDIR)$(private_libexecdir)/$$j || exit 1; \
done
endif
endif

ifeq ($(OS), Darwin)
ifneq ($(DARWIN_FRAMEWORK),1)
for j in $(JL_PRIVATE_EXES) ; do \
[ $$j = 7z ] && continue; \
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vtjnash was this line supposed to be removed in #60098 ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this prevented it from getting set correctly during install

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may still need to delete this for the patch to be applied

@KristofferC KristofferC deleted the branch JuliaLang:backports-release-1.12 December 19, 2025 12:38
@nhz2
Copy link
Copy Markdown
Member Author

nhz2 commented Dec 21, 2025

@KristofferC Is there a way to backport this fix to 1.12? I just tested this, and it allows Julia to run and install packages in a container with the system libstdc++.so files removed.

@DilumAluthge DilumAluthge reopened this Dec 22, 2025
@DilumAluthge
Copy link
Copy Markdown
Member

Looks like this was auto-closed when the backports PR was merged. I've created a new backports branch.

@DilumAluthge DilumAluthge force-pushed the nz/backport-1.12-p7zip-rpath-fix branch from 2f26e1b to 041af6a Compare December 22, 2025 01:18
@DilumAluthge DilumAluthge requested a review from vtjnash December 22, 2025 01:18
@DilumAluthge
Copy link
Copy Markdown
Member

@vtjnash Can you review this?

@DilumAluthge DilumAluthge marked this pull request as ready for review December 22, 2025 01:20
@DilumAluthge
Copy link
Copy Markdown
Member

Julia 1.12.4 is in testing period currently.

I think we should probably wait until 1.12.4 is released. After that, a new backports PR will be opened (for the future 1.12.5), and then we can merge this PR into the 1.12 backports branch.

@nhz2 Can you ping me once 1.12.4 has been released?

@KristofferC
Copy link
Copy Markdown
Member

I think we should get this into 1.12.4. It is a bugfix to an existing 1.12 issue.

@KristofferC KristofferC merged commit 4539b7b into JuliaLang:backports-release-1.12 Dec 22, 2025
8 checks passed
@nhz2 nhz2 deleted the nz/backport-1.12-p7zip-rpath-fix branch December 23, 2025 17:21
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jan 16, 2026
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants