Clarify that cpu_info times are expressed in milliseconds#60480
Merged
topolarity merged 8 commits intoJuliaLang:masterfrom Dec 27, 2025
Merged
Clarify that cpu_info times are expressed in milliseconds#60480topolarity merged 8 commits intoJuliaLang:masterfrom
cpu_info times are expressed in milliseconds#60480topolarity merged 8 commits intoJuliaLang:masterfrom
Conversation
Contributor
|
Since this is coming from libuv, we probably shouldn't care about other systems. |
Member
|
@topolarity Are you willing to review this? |
Member
|
This change seems well-motivated to me, but |
topolarity
reviewed
Dec 26, 2025
topolarity
added
backport 1.10
topolarity
approved these changes
Dec 27, 2025
Member
topolarity
left a comment
topolarity
left a comment
There was a problem hiding this comment.
Thanks! This has been wrong for... a long time (since 1.6 at least)
topolarity
reviewed
Dec 27, 2025
Co-authored-by: Cody Tapscott <84105208+topolarity@users.noreply.github.com>
KristofferC
pushed a commit
that referenced
this pull request
Jan 7, 2026
libuv reports times in milliseconds, but the Julia docs and show() use units of 1/Sys.SC_CLK_TCK which is 100 on my laptop. The mismatch might be due to libuv changeset libuv/libuv@37a8aff. Fixes #53577 (cherry picked from commit 3d611fd)
KristofferC
pushed a commit
that referenced
this pull request
Jan 8, 2026
libuv reports times in milliseconds, but the Julia docs and show() use units of 1/Sys.SC_CLK_TCK which is 100 on my laptop. The mismatch might be due to libuv changeset libuv/libuv@37a8aff. Fixes #53577 (cherry picked from commit 3d611fd)
KristofferC
pushed a commit
that referenced
this pull request
Jan 9, 2026
libuv reports times in milliseconds, but the Julia docs and show() use units of 1/Sys.SC_CLK_TCK which is 100 on my laptop. The mismatch might be due to libuv changeset libuv/libuv@37a8aff. Fixes #53577 (cherry picked from commit 3d611fd)
DilumAluthge
pushed a commit
that referenced
this pull request
Jan 9, 2026
libuv reports times in milliseconds, but the Julia docs and show() use units of 1/Sys.SC_CLK_TCK which is 100 on my laptop. The mismatch might be due to libuv changeset libuv/libuv@37a8aff. Fixes #53577 (cherry picked from commit 3d611fd)
71 tasks
45 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53577
Main thing I'm not sure of is if there are still some systems where these values might have unknown units?