Improve error message for credential failures in non-interactive environments#60682
Open
Yashagarwal9798 wants to merge 2 commits intoJuliaLang:masterfrom
Open
Improve error message for credential failures in non-interactive environments#60682Yashagarwal9798 wants to merge 2 commits intoJuliaLang:masterfrom
Yashagarwal9798 wants to merge 2 commits intoJuliaLang:masterfrom
Conversation
Member
|
@Yashagarwal9798 Just to check, did you use any generative AI tools to write the code or the PR description? |
Contributor
Author
|
Yes, I used generative AI to help refine the implementation and description after performing a detailed manual analysis of the issue. I have carefully reviewed all the code to ensure it meets Julia's standards and correctly addresses the problem |
Member
|
Please disclose the use of generative AI when you open the PR. This is a requirement of the Julia repo, documented in CONTRIBUTING.md. I notice that you were also reminded of this requirement previously: #60640 (comment) |
Contributor
Author
|
Understood. I apologize for the oversight and will ensure all future PRs include the required AI disclosure as per the contribution guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59341
Summary
This PR improves error reporting when SSH or User/Pass authentication fails in non-interactive environments (e.g., CI/CD pipelines). It replaces the misleading
GitError: user cancelled credential requestwith a detailed error message offering actionable solutions.Changes
stdlib/LibGit2/src/callbacks.jl: Introducedexhausted_abort_noninteractive(). This helper is now called byauthenticate_sshandauthenticate_userpasswhen credentials fail andallow_prompt=false.stdlib/LibGit2/test/libgit2-tests.jl: Updated 5 existing tests to verify the new, descriptive error message is thrown.New Error Output
Instead of "user cancelled", users will now see:
Testing
allow_prompt=falsetriggers the new error message instead of the generic GitError.