inference: include const-abi CodeInstances in need_inlineable_code check#61553
Merged
adienes merged 1 commit intoJuliaLang:masterfrom Apr 10, 2026
Merged
inference: include const-abi CodeInstances in need_inlineable_code check#61553adienes merged 1 commit intoJuliaLang:masterfrom
adienes merged 1 commit intoJuliaLang:masterfrom
Conversation
Const-abi CodeInstances have `inferred === nothing`, so `is_inlineable` returns false and `typeinf_edge` skips source retrieval. This prevents the inliner from folding these calls to constants. Fixes JuliaLang#61552 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
adienes
added
bugfix
Member
|
Should we instead make |
Member
Author
|
not sure I fully understand the suggestion. iiuc |
vtjnash
approved these changes
Apr 10, 2026
JamesWrigley
pushed a commit
to JamesWrigley/julia
that referenced
this pull request
Apr 13, 2026
…eck (JuliaLang#61553) Const-abi CodeInstances have `inferred === nothing`, so `is_inlineable` returns false and `typeinf_edge` skips source retrieval. This prevents the inliner from folding these calls to constants. Fixes JuliaLang#61552 can't wait for Mythos to release and then maybe claude will be able to take over all my other hobbies too Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Const-abi CodeInstances have
inferred === nothing, sois_inlineablereturns false andtypeinf_edgeskips source retrieval. This prevents the inliner from folding these calls to constants.Fixes #61552
can't wait for Mythos to release and then maybe claude will be able to take over all my other hobbies too