Adjustment to AdjointQ introduction in LinearAlgebra#91
Merged
dkarrasch merged 7 commits intoJuliaLinearAlgebra:masterfrom Nov 29, 2022
Merged
Adjustment to AdjointQ introduction in LinearAlgebra#91dkarrasch merged 7 commits intoJuliaLinearAlgebra:masterfrom
AdjointQ introduction in LinearAlgebra#91dkarrasch merged 7 commits intoJuliaLinearAlgebra:masterfrom
Conversation
Codecov ReportBase: 81.29% // Head: 81.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 81.29% 81.67% +0.37%
==========================================
Files 10 10
Lines 1636 1626 -10
==========================================
- Hits 1330 1328 -2
+ Misses 306 298 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dkarrasch
force-pushed
the
dk/adjointq
branch
from
aede9ab to
34e1f79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a companion PR to JuliaLang/julia#46196.
It will fail for the nightly version until that PR is merged (if it gets merged).It should no longer fail because it checks ifAdjointQis defined, independently from any versions. In principle, if we agree on merging the stdlib PR, we could merge this even before that PR, release a new version and then it should no longer fail on eithermasterorPR.